Skip to content

SONARJAVA-6218 Prepare a basic project in sonar-java to use for running ruling samples#5540

Merged
asya-vorobeva merged 1 commit intomasterfrom
asya/create-vibe-bot-project
Mar 30, 2026
Merged

SONARJAVA-6218 Prepare a basic project in sonar-java to use for running ruling samples#5540
asya-vorobeva merged 1 commit intomasterfrom
asya/create-vibe-bot-project

Conversation

@asya-vorobeva
Copy link
Copy Markdown
Contributor

@asya-vorobeva asya-vorobeva commented Mar 30, 2026

Part of SONARJAVA-6218.

@sonar-review-alpha
Copy link
Copy Markdown
Contributor

sonar-review-alpha Bot commented Mar 30, 2026

Summary

Introduces a new sample project 'vibebot' to the ruling test suite. This is a minimal Java 21 project used for testing SonarQube's Java analyzer rules (ruling tests), with expected violation fixtures for three rules (S1120, S1228, S1451). The project is intentionally excluded from GitHub Actions since vibe-bot handles its own testing. Also removes an obsolete JBoss-specific test profile and improves test setup (creates performance directory, makes paths absolute).

What reviewers should know

What changed: The core addition is the new its/vibebot/ directory—a bare-bones Maven project with one Java class. Start by reviewing the App.java to understand what violations it's expected to trigger. Then check its/ruling/src/test/resources/vibebot/ for the expected JSON fixtures—these define which rules should fire and on which lines. In JavaRulingTest.java, the new vibebot() test method is boilerplate (follows the same pattern as other test methods). Key detail: The test is excluded from normal CI via the pom.xml change—this is intentional because vibe-bot (a separate system) will run this test instead. Minor notes: Removed an unused Maven profile and made a path absolute for consistency.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown
Contributor

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean, well-scoped PR. The new vibebot project is minimal by design, its expected rule violations are intentional and correctly captured in the snapshot JSON files, and the infrastructure fixes (absolute performance path, directory pre-creation) are sound.

🗣️ Give feedback

Comment thread its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java
@asya-vorobeva asya-vorobeva force-pushed the asya/create-vibe-bot-project branch from da68cba to b0d61b0 Compare March 30, 2026 13:31
@asya-vorobeva asya-vorobeva enabled auto-merge (squash) March 30, 2026 13:33
@sonarqube-next
Copy link
Copy Markdown

@asya-vorobeva asya-vorobeva merged commit 388e1a6 into master Mar 30, 2026
15 of 16 checks passed
@asya-vorobeva asya-vorobeva deleted the asya/create-vibe-bot-project branch March 30, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants