SONARJAVA-6289 Fix QG / Fix issues with stream().foreach(...)

[rombirli]

No description provided.

[hashicorp-vault-sonar-prod]

SONARJAVA-6289

[sonar-review-alpha]

Summary

This PR removes unnecessary .stream() chains from forEach() operations and replaces a stream+forEach pattern with direct collection operations. The changes address three instances where streams were being used inefficiently:

1. ValueBasedUtilsTest: Changed members.stream().forEach(...) to members.forEach(...)
2. SonarComponents: Changed undefinedTypes.stream().forEach(...) to undefinedTypes.forEach(...)
3. DefaultJavaFileScannerContext: Replaced mainLocations.subList(...).stream().forEach(completedSecondaries::add) with completedSecondaries.addAll(mainLocations.subList(...))

These are performance and clarity improvements—using the built-in forEach() method on collections and addAll() is simpler and more efficient than creating an unnecessary stream layer.

What reviewers should know

What to look for:

• All three changes follow the same pattern: eliminating redundant streams
• The functional behavior is identical—this is purely a refactoring for code quality
• Changes affect one test file and two production files

Review strategy:

• Verify that each change maintains the original behavior (it should—they're direct simplifications)
• Check if there are other similar patterns in the codebase that might need the same treatment
• Confirm the modifications compile and tests still pass

---

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
3 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[sonar-review-alpha]

LGTM! ✅

Clean, straightforward PR. All three changes are behaviorally equivalent and correct:

• completedSecondaries is a fresh ArrayList (line 106), so addAll is safe and idiomatic.
• undefinedTypes is a Set<JProblem> — iteration order was never guaranteed by either approach.
• The (VariableTree) cast in the test is safe: the fixture class contains only field declarations, so members will never contain a non-VariableTree element.

🗣️ Give feedback

[tomasz-tylenda-sonarsource]

@NoemieBenard Fyi, this use of forEach(collection::add) is another thing that may benefit from simplification.

No action needed.