Skip to content

SONARJAVA-6328 Modify S8688: lower severity and re-enable in Sonar way#5632

Merged
NoemieBenard merged 3 commits into
masterfrom
nb/S8688-update-metadata
May 27, 2026
Merged

SONARJAVA-6328 Modify S8688: lower severity and re-enable in Sonar way#5632
NoemieBenard merged 3 commits into
masterfrom
nb/S8688-update-metadata

Conversation

@NoemieBenard
Copy link
Copy Markdown
Contributor

@NoemieBenard NoemieBenard commented May 27, 2026

Part of


Summary by Gitar

  • Rule S8688 metadata updates:
    • Changed defaultSeverity from Major to Info in S8688.json.
    • Updated MAINTAINABILITY and RELIABILITY impact levels to INFO.
  • Profile updates:
    • Enabled rule S8688 by adding it to Sonar_way_profile.json.
  • Autoscan tests:
    • Added new test resource file diff_S2143.json for rule S8688 verification.

This will update automatically on new commits.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown
Contributor

hashicorp-vault-sonar-prod Bot commented May 27, 2026

SONARJAVA-6328

Comment thread its/autoscan/src/test/resources/autoscan/diffs/diff_S8688.json
@sonarqube-next
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@NoemieBenard NoemieBenard merged commit 2a0307a into master May 27, 2026
15 checks passed
@NoemieBenard NoemieBenard deleted the nb/S8688-update-metadata branch May 27, 2026 11:27
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 27, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Updates S8688 metadata to lower severity and enables the rule in the Sonar way profile, resolving the mismatched test resource file name.

✅ 1 resolved
Bug: Filename diff_S2143.json doesn't match ruleKey S8688

📄 its/autoscan/src/test/resources/autoscan/diffs/diff_S2143.json:1-6
The new file is named diff_S2143.json but contains "ruleKey": "S8688". All other files in this directory follow the convention diff_{ruleKey}.json (e.g., diff_S100.json contains "ruleKey": "S100"). This mismatch will likely cause the autoscan test infrastructure to either not pick up the diff for S8688, or incorrectly associate it with S2143.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants