SONARJAVA-1689 Migrate to LTS#845
Conversation
| @@ -116,10 +113,6 @@ public Highlightable highlightableFor(File file) { | |||
| return resourcePerspectives.as(Highlightable.class, inputFromIOFile(file)); | |||
There was a problem hiding this comment.
Remove this use of "Highlightable"; it is deprecated. 
| @@ -38,7 +38,7 @@ public JavaIssue(NewIssue newIssue) { | |||
| public static JavaIssue create(SensorContext context, RuleKey ruleKey, @Nullable Double effortToFix) { | |||
There was a problem hiding this comment.
Remove this use of "SensorContext"; it is deprecated.
| <groupId>org.sonarsource.sonarqube</groupId> | ||
| <artifactId>sonar-plugin-api</artifactId> | ||
| <scope>provided</scope> | ||
| </dependency> |
There was a problem hiding this comment.
@benzonico slf4j-api is still provided at runtime, even if it is not transitive dependency of sonar-plugin-api, so that you can reduce size of plugin by declaring:
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<scope>provided</scope>
</dependency>
Also you package jcl-over-slf4j - I don't know if this one is also provided at runtime, but maybe it is even not need for Java plugin and can be completely excluded.
There was a problem hiding this comment.
@benzonico but ultimately usage of slf4j-api should be removed - see https://jira.sonarsource.com/browse/SONAR-5700
There was a problem hiding this comment.
|
@benzonico you can also remove |
3 participants
No description provided.