SONARPY-962 Cleanup Typeshed class and fix FQN of methods of class symbols inheriting from private typeshed symbols#1047
Merged
andrea-guarino-sonarsource merged 4 commits intoMMF-2578from Jan 10, 2022
Conversation
andrea-guarino-sonarsource
force-pushed
the
SONARPY-962
branch
2 times, most recently
from
f3a1aff to
f118014
Compare
andrea-guarino-sonarsource
changed the title
andrea-guarino-sonarsource
force-pushed
the
SONARPY-962
branch
4 times, most recently
from
b8269a6 to
3ca0ae9
Compare
guillaume-dequenne
approved these changes
Jan 10, 2022
Contributor
guillaume-dequenne
left a comment
guillaume-dequenne
left a comment
There was a problem hiding this comment.
LGTM, thanks for the refactoring of the TypeShed class, it makes things much clearer.
I left a minor renaming suggestion, feel free to actually implement it or not.
Contributor
There was a problem hiding this comment.
Now that we have actual Descriptor classes, perhaps it would be better to rename this concept ProtobufDescriptor or something similar to clearly distinguish them.
andrea-guarino-sonarsource
force-pushed
the
SONARPY-962
branch
from
3ca0ae9 to
33e3531
Compare
|
SonarQube Quality Gate
|
hashicorp-vault-sonar-prod bot
pushed a commit
that referenced
this pull request
Apr 7, 2026
GitOrigin-RevId: 4088afedaa3541b3d30fe804b95102aedd1f3a88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.