SONARPY-961 Typeshed: serialize only public import #1073
Merged
Conversation
guillaume-dequenne
force-pushed
the
SONARPY-961
branch
from
a8c76dd to
8c62028
Compare
andrea-guarino-sonarsource
approved these changes
Feb 4, 2022
Contributor
andrea-guarino-sonarsource
left a comment
andrea-guarino-sonarsource
left a comment
There was a problem hiding this comment.
Looks great! I think we could add a unit test in the serializer for from module import *
Contributor
There was a problem hiding this comment.
unnecessary change?
Contributor
There was a problem hiding this comment.
I think we miss a test with from library import *
Can we maybe add a fakeImportedModule and do from fakeImportedModule import * ?
guillaume-dequenne
force-pushed
the
SONARPY-961
branch
from
a3dbb4f to
1f88fcf
Compare
guillaume-dequenne
force-pushed
the
SONARPY-961
branch
from
1f88fcf to
aa1b508
Compare
|
SonarQube Quality Gate
|
andrea-guarino-sonarsource
approved these changes
Feb 4, 2022
hashicorp-vault-sonar-prod Bot
pushed a commit
that referenced
this pull request
Apr 24, 2026
#1073) Co-authored-by: Vibe Bot <vibe-bot@sonarsource.com> GitOrigin-RevId: 7bdde59ec9c6b50dfd3d7e32d6e61c1cabd0c302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.