Skip to content

Conversation

gcaill19
Copy link

@gcaill19 gcaill19 commented Mar 22, 2018

sonar-python plugin is only aware of pylint rules up to 1.2.1 which is already 4 years old.
This Pull request intend to catch-up up to version 1.8.3, supporting ~100 more rules.
This PR is necessary to keep the pylint integration meaningful.

@gcaill19
Copy link
Author

This PR is a proactive effort to answer my own question https://groups.google.com/forum/#!topic/sonarqube/ezXW03MzzYU

@gcaill19
Copy link
Author

@pynicolas can you please review this PR?

@pynicolas
Copy link
Contributor

Thanks a lot for the PR! Indeed, updating the list of pylint rules should be done more often.

I have 2 remarks about the content of the PR:

  • Rules should not be deleted (e.g. C0322): users relying on an old version of pylint should still be able to have their issues imported.
  • Preserving the existing indentation of rules.xml would make it much easier to review the changes (we don't care much about rules_generated.xml).

I'll try to handle those 2 points at the end of next week if nobody has done it before.

Thanks again!

@gcaill19
Copy link
Author

Thanks @pynicolas, that will be much appreciated here. Let me know if you can't make it and I'll give it a try even though I'm no expert at all in merging XMLs.

Thanks.

@pynicolas
Copy link
Contributor

@clarkgaybel I opened PR #149 based on what you did. Please have a look at it and test it.

@pynicolas
Copy link
Contributor

This PR was replaced by #149 which was heavily based on this one. Thanks!

@pynicolas pynicolas closed this Apr 16, 2018
@pynicolas
Copy link
Contributor

@tquenolle @AubryH This change should be released as part of SonarPython 1.10. Please see the request for feedback. Thanks!

hashicorp-vault-sonar-prod bot pushed a commit that referenced this pull request Mar 19, 2025
GitOrigin-RevId: 1f6b9e7e87a465803fd07cc0d54173a07419c427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants