SONARPY-280 Update rule definitions for pylint 1.8 #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pynicolas
changed the title
vilchik-elena
approved these changes
Apr 13, 2018
| List<RulesDefinition.Rule> rules = repository.rules(); | ||
| assertThat(rules).isNotNull(); | ||
| assertThat(rules).hasSize(180); | ||
| assertThat(rules).hasSize(322); |
There was a problem hiding this comment.
@pynicolas I noticed inconsistency: we declare 322 rules, but there are 328 entries in remediation cost file.
Also while there are 142 rules added in rules.xml, there are only 116 added in rules_generated.
There was a problem hiding this comment.
@vilchik-elena I fixed the first inconsistencies you noticed in d632d01. We now define 325 rules.
The second set of inconsistencies is due to the rules which were removed by pylint and which we still want to define: these rules were removed from rules_generated.xml but not from rules.xml.
Thanks!
|
Thanks for your response time @pynicolas ! much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.