Update jarjar package names - fixes SONARPY-283#179
Closed
ewjmulder wants to merge 1 commit intoSonarSource:masterfrom
Closed
Update jarjar package names - fixes SONARPY-283#179ewjmulder wants to merge 1 commit intoSonarSource:masterfrom
ewjmulder wants to merge 1 commit intoSonarSource:masterfrom
Conversation
Member
|
Thanks @ewjmulder for your contribution! I merged your commit from the internal pull request #185 to benefit from more CI checks, so I can close this pull request, your commit is already on master. |
hashicorp-vault-sonar-prod Bot
pushed a commit
that referenced
this pull request
Apr 8, 2025
GitOrigin-RevId: c50e4efa055be437b4ba7659db9540c9b8bb295c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After running into https://stackoverflow.com/questions/50730049/error-running-sonar-sslr-toolkit and seeing https://jira.sonarsource.com/browse/SONARPY-283 I dug a little deeper and found the cause: the package names in the jarjar includes list are outdated. This commit corrects that and I can confirm the SSLR standalone application for Python is working again correctly.
P.S. The same issue is present in the sonar-flex project - sslr module. Will you fix it or shall I create a PR for that one as well?