SONARPY-263 Import unit tests execution reports generated by py.test#187
Merged
christophe-zurn-sonarsource merged 5 commits intomasterfrom Jan 30, 2019
Merged
SONARPY-263 Import unit tests execution reports generated by py.test#187christophe-zurn-sonarsource merged 5 commits intomasterfrom
christophe-zurn-sonarsource merged 5 commits intomasterfrom
Conversation
ghost
approved these changes
Jan 30, 2019
| LOG.debug("Saving test execution measures for '{}'", inputFile.toString()); | ||
|
|
||
| saveMeasure(context, inputFile, CoreMetrics.SKIPPED_TESTS, fileTestResult.getSkipped()); | ||
| saveMeasure(context, inputFile, CoreMetrics.TESTS, fileTestResult.getTests() - fileTestResult.getSkipped()); |
There was a problem hiding this comment.
I would explicitly have this in the TestResult class, called getExecutedTests(), so you don't have to do the substraction everywhere.
hashicorp-vault-sonar-prod Bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
GitOrigin-RevId: 9fc1d6e48c9376d3a01c8560e729ad18ef5fe0e2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.