-
Notifications
You must be signed in to change notification settings - Fork 102
SONARPY-353 Use semantic engine from PyCharm and migrate S4823 (CommandLineArgsCheck) hotspot rule #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
SONARPY-353 Use semantic engine from PyCharm and migrate S4823 (CommandLineArgsCheck) hotspot rule #259
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0871355
wip
mpaladin 4dd6211
wip2
mpaladin 9225425
Test
mpaladin 4e447e9
Add PythonWindowsFlavourSDK service
andreaguarino 52d240a
update ruling and UT for S4823. Add more comments
andreaguarino d481f0e
some refactoring
andreaguarino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
python-checks/src/main/java/org/sonar/python/checks/AbstractCallExpressionBase.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| * SonarQube Python Plugin | ||
| * Copyright (C) 2011-2019 SonarSource SA | ||
| * mailto:info AT sonarsource DOT com | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Lesser General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 3 of the License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public License | ||
| * along with this program; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
| package org.sonar.python.checks; | ||
|
|
||
| import com.intellij.psi.PsiElement; | ||
| import com.jetbrains.python.PyElementTypes; | ||
| import com.jetbrains.python.psi.PyCallExpression; | ||
| import com.jetbrains.python.psi.PyClass; | ||
| import com.jetbrains.python.psi.PyExpression; | ||
| import com.jetbrains.python.psi.PyFunction; | ||
| import com.jetbrains.python.psi.PyReferenceExpression; | ||
| import java.util.Set; | ||
| import org.sonar.python.PythonCheck; | ||
|
|
||
| public abstract class AbstractCallExpressionBase extends PythonCheck { | ||
|
|
||
| protected abstract Set<String> functionsToCheck(); | ||
|
|
||
| protected abstract String message(); | ||
|
|
||
| protected boolean isException(PsiElement node) { | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public void initialize(Context context) { | ||
| context.registerSyntaxNodeConsumer(PyElementTypes.CALL_EXPRESSION, ctx -> { | ||
| PyCallExpression node = (PyCallExpression) ctx.syntaxNode(); | ||
| PyExpression callee = node.getCallee(); | ||
| if (callee instanceof PyReferenceExpression) { | ||
| PsiElement resolve = ((PyReferenceExpression) callee).getReference().resolve(); | ||
| if (resolve instanceof PyFunction) { | ||
| PyFunction pyFunction = (PyFunction) resolve; | ||
| PyClass containingClass = pyFunction.getContainingClass(); | ||
| if (containingClass != null) { | ||
| String qualifiedName = containingClass.getQualifiedName(); | ||
| if (!isException(node) && functionsToCheck().contains(qualifiedName + "." + pyFunction.getName())) { | ||
| ctx.addIssue(node, message()); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about having a more useful type for
node?In fact, this method is useless so far since it's never overridden.