SONARPY-380 Add parent and children to Python Tree, migrate EmptyNestedBlockCheck, PreIncrementDecrementCheck#275
Merged
andrea-guarino-sonarsource merged 3 commits intomasterfrom Aug 30, 2019
Conversation
andrea-guarino-sonarsource
force-pushed
the
SONARPY-380d
branch
from
8a7af53 to
c22f5d9
Compare
andrea-guarino-sonarsource
changed the title
andrea-guarino-sonarsource
changed the title
pynicolas
reviewed
Aug 29, 2019
| assertThat(raiseStatement.fromKeyword().getValue()).isEqualTo("from"); | ||
| assertThat(raiseStatement.fromExpression()).isNotNull(); | ||
| assertThat(raiseStatement.expressions()).hasSize(1); | ||
| assertThat(raiseStatement.children()).hasSize(2); |
Contributor
There was a problem hiding this comment.
Is that change intended?
Contributor
There was a problem hiding this comment.
I would not add this method to Tree, only to PyStatementListTree, at least for the moment.
andrea-guarino-sonarsource
force-pushed
the
SONARPY-380d
branch
from
f8a1e3e to
a88a5a4
Compare
hashicorp-vault-sonar-prod Bot
pushed a commit
that referenced
this pull request
May 26, 2025
Co-authored-by: Thomas Serre <118730793+thomas-serre-sonarsource@users.noreply.github.com> GitOrigin-RevId: 3f7a97bc58dd2d5d30df1e4bc82e3755b466c477
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.