SONARPY-376 Rule S5443: Using publicly writable directories is securi…#284
Merged
andrea-guarino-sonarsource merged 3 commits intomasterfrom Sep 3, 2019
Merged
SONARPY-376 Rule S5443: Using publicly writable directories is securi…#284andrea-guarino-sonarsource merged 3 commits intomasterfrom
andrea-guarino-sonarsource merged 3 commits intomasterfrom
Conversation
pynicolas
reviewed
Sep 3, 2019
Contributor
There was a problem hiding this comment.
I think we could refine that to avoid some FPs:
open("/tmpx")
open("C:\Temperatures")
andrea-guarino-sonarsource
force-pushed
the
SONARPY-376
branch
from
e90af05 to
4d4da1c
Compare
andrea-guarino-sonarsource
force-pushed
the
SONARPY-376
branch
from
4d4da1c to
939fe0a
Compare
pynicolas
reviewed
Sep 3, 2019
Contributor
pynicolas
left a comment
pynicolas
left a comment
There was a problem hiding this comment.
Please check the issues raised by SonarQube on the PR.
Otherwise, LGTM.
|
|
||
| private boolean isNonCompliantOsEnvironArgument(Tree tree) { | ||
| Tree argumentOrExpression = tree; | ||
| if (tree.is(Kind.ARGUMENT)) { |
Contributor
There was a problem hiding this comment.
I think we could remove this if and add .map(PyArgumentTree::expression) at line 64.
hashicorp-vault-sonar-prod Bot
pushed a commit
that referenced
this pull request
May 27, 2025
…rewrite using <dict/list/set>() (#284) GitOrigin-RevId: 768bf94a77a026b1ab76c1b9abe5b5d7ddb58165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ty-sensitive