Migrate ReturnYieldOutsideFunction check to Strongly typed AST#290
Merged
guillaume-dequenne merged 3 commits intomasterfrom Sep 3, 2019
Merged
Migrate ReturnYieldOutsideFunction check to Strongly typed AST#290guillaume-dequenne merged 3 commits intomasterfrom
guillaume-dequenne merged 3 commits intomasterfrom
Conversation
guillaume-dequenne
force-pushed
the
migrate_ReturnYieldOutsideFunction
branch
from
3a1fc69 to
bf0c75f
Compare
benzonico
requested changes
Sep 3, 2019
| public void visitNode(AstNode node) { | ||
| AstNode currentParent = node.getParent(); | ||
| private static final Consumer<SubscriptionContext> SUBSCRIPTION_CONTEXT_CONSUMER = ctx -> { | ||
| PyStatementTree returnStatement = ((PyStatementTree) ctx.syntaxNode()); |
Contributor
There was a problem hiding this comment.
Useless parentheses around the expression can be removed.
benzonico
approved these changes
Sep 3, 2019
hashicorp-vault-sonar-prod Bot
pushed a commit
that referenced
this pull request
May 28, 2025
GitOrigin-RevId: dca9fffc4f550a473a00b0718a72434775b22063
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.