Skip to content

Migrate BlackSlashInStringCheck to Strongly typed AST#293

Merged
benzonico merged 2 commits intomasterfrom
migrate_BackslashInStringCheck
Sep 6, 2019
Merged

Migrate BlackSlashInStringCheck to Strongly typed AST#293
benzonico merged 2 commits intomasterfrom
migrate_BackslashInStringCheck

Conversation

@guillaume-dequenne
Copy link
Copy Markdown
Contributor

No description provided.

@guillaume-dequenne guillaume-dequenne force-pushed the migrate_BackslashInStringCheck branch from 8daf7ea to 38b0df5 Compare September 4, 2019 12:23
@guillaume-dequenne guillaume-dequenne force-pushed the migrate_BackslashInStringCheck branch from 5e7c1a2 to df78b9f Compare September 6, 2019 10:05
@guillaume-dequenne guillaume-dequenne force-pushed the migrate_BackslashInStringCheck branch from 33b5ca2 to 6c5439a Compare September 6, 2019 12:12
Copy link
Copy Markdown
Contributor

@benzonico benzonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, two small updates are required.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unecessary change.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import should be removed.

@guillaume-dequenne guillaume-dequenne force-pushed the migrate_BackslashInStringCheck branch from 6c5439a to 0a4fbec Compare September 6, 2019 13:00
@benzonico benzonico self-requested a review September 6, 2019 15:38
@benzonico benzonico merged commit b9fd0db into master Sep 6, 2019
@benzonico benzonico deleted the migrate_BackslashInStringCheck branch September 6, 2019 15:38
hashicorp-vault-sonar-prod Bot pushed a commit that referenced this pull request Jun 2, 2025
GitOrigin-RevId: 8003cf4855dee239dc1f9ae8ddadd9288109e602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants