Skip to content

SONARPY-407 CallExpression: ArgList should be null if there are no parameters#314

Merged
andrea-guarino-sonarsource merged 3 commits intomasterfrom
call-expr-arglist
Sep 11, 2019
Merged

SONARPY-407 CallExpression: ArgList should be null if there are no parameters#314
andrea-guarino-sonarsource merged 3 commits intomasterfrom
call-expr-arglist

Conversation

@andrea-guarino-sonarsource
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@pynicolas pynicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may think about having a dedicated method on CallExpression.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could factorize that code in a "argList" method which could return null.

@andrea-guarino-sonarsource andrea-guarino-sonarsource changed the title CallExpression: ArgList should be null if there are no parameters SONARPY-407 CallExpression: ArgList should be null if there are no parameters Sep 11, 2019
@andrea-guarino-sonarsource andrea-guarino-sonarsource merged commit a19f79c into master Sep 11, 2019
@andrea-guarino-sonarsource andrea-guarino-sonarsource deleted the call-expr-arglist branch September 11, 2019 09:04
hashicorp-vault-sonar-prod bot pushed a commit that referenced this pull request Jun 6, 2025
GitOrigin-RevId: 85e9c524235197fb536f7c1e27508f59881c0d50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants