Skip to content

Migrate OneStatementPerLineCheck to Strongly typed AST#329

Merged
benzonico merged 1 commit intomasterfrom
migrate_OneStatementPerLine
Sep 18, 2019
Merged

Migrate OneStatementPerLineCheck to Strongly typed AST#329
benzonico merged 1 commit intomasterfrom
migrate_OneStatementPerLine

Conversation

@guillaume-dequenne
Copy link
Copy Markdown
Contributor

No description provided.

@guillaume-dequenne guillaume-dequenne force-pushed the migrate_OneStatementPerLine branch 8 times, most recently from e5072fb to eb806b2 Compare September 17, 2019 13:15
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just have an array of Kind and iterate over it ?

List<Kind> kinds = Arrays.asList (Tree.Kind.., 

.... ) ;

//...
initialize (...) {
... 
kinds.foreach(k -> context.registerSyntaxNodeConsumer(k, this::checkStatement);
}

@guillaume-dequenne guillaume-dequenne force-pushed the migrate_OneStatementPerLine branch 2 times, most recently from 4ec3e30 to 681eb0c Compare September 17, 2019 15:24
@benzonico benzonico merged commit a25b124 into master Sep 18, 2019
@benzonico
Copy link
Copy Markdown
Contributor

LGTM !

@benzonico benzonico deleted the migrate_OneStatementPerLine branch September 18, 2019 07:23
hashicorp-vault-sonar-prod bot pushed a commit that referenced this pull request Jun 24, 2025
GitOrigin-RevId: 4011a8a9b125c1c0630ea0aeb9038491533687f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants