Skip to content

Remove ast node from pyTree implementations#389

Merged
guillaume-dequenne merged 5 commits into
masterfrom
remove_ast_node_dep
Oct 8, 2019
Merged

Remove ast node from pyTree implementations#389
guillaume-dequenne merged 5 commits into
masterfrom
remove_ast_node_dep

Conversation

@benzonico

Copy link
Copy Markdown
Contributor

No description provided.

@benzonico benzonico force-pushed the remove_ast_node_dep branch 2 times, most recently from 3d70297 to 90fe2cf Compare October 7, 2019 14:28

@guillaume-dequenne guillaume-dequenne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions

Comment thread python-squid/src/main/java/org/sonar/python/tree/ExpressionListImpl.java Outdated
Comment thread python-squid/src/main/java/org/sonar/python/tree/PyTree.java Outdated
Comment thread python-squid/src/main/java/org/sonar/python/tree/PyTree.java Outdated
Comment thread python-squid/src/main/java/org/sonar/python/tree/TupleParameterImpl.java Outdated
@benzonico benzonico force-pushed the remove_ast_node_dep branch from 90fe2cf to 66562fd Compare October 7, 2019 15:56

@guillaume-dequenne guillaume-dequenne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guillaume-dequenne guillaume-dequenne merged commit 2823867 into master Oct 8, 2019
@guillaume-dequenne guillaume-dequenne deleted the remove_ast_node_dep branch October 8, 2019 07:42
hashicorp-vault-sonar-prod Bot pushed a commit that referenced this pull request Jul 21, 2025
GitOrigin-RevId: b41ec5c2144295cfba70211cb75ce4b88f89e366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants