SONARPY-471 Rule S2190: Recursion should not be infinite

[alban-auzeill]

No description provided.

[andrea-guarino-sonarsource]

Could you please add a test case in CheckUtilsTest for this?

[andrea-guarino-sonarsource]

Nitpicking: could you please add newline here?

[andrea-guarino-sonarsource]

I think we could add a test case to document the following FN:

def f(p):
  return f(p) if p else f(p) # FN

[andrea-guarino-sonarsource]

I think we could add a test case to document the following FN:

def fn():
  if fn() or x == 10:
     ...

[alban-auzeill]

Nop, there's no FN, visitBinaryExpression always takes into account leftOperand() recursion, even for or and and.
I added the following test:

def fun21(x): # Noncompliant
    if fun21(x + 1) or x == 10:
        print(2)

[andrea-guarino-sonarsource]

It's not very clear to me why we're excluding for statements. Is it for a limitation in the CFG? In that case, please create a ticket for it and document in the unit tests

[alban-auzeill]

Now, I think it's useless. It was probably useful before I exclude lambda or sub-function, but it was not the right workaround. So I removed this visitForStatement and added more test related to for.