Skip to content

SONARPY-663 Rule S5780: Expressions creating dictionaries should not … #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guillaume-dequenne merged 3 commits into from
May 13, 2020
Merged

SONARPY-663 Rule S5780: Expressions creating dictionaries should not … #712

guillaume-dequenne merged 3 commits into from
May 13, 2020

Conversation

@guillaume-dequenne
Copy link
Contributor

@guillaume-dequenne guillaume-dequenne commented May 8, 2020

…have duplicate keys

@guillaume-dequenne guillaume-dequenne force-pushed the SONARPY-663 branch 5 times, most recently from bd86b13 to b8d93db Compare May 11, 2020 07:11
andrey-tyukin-sonarsource
andrey-tyukin-sonarsource reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@andrey-tyukin-sonarsource andrey-tyukin-sonarsource left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quadratic runtime of the all-vs-all comparison seems risky - maybe we could exclude the dangerous cases to make sure the analyzer doesn't freeze suddenly. Several other potential sources for both false negatives and false positives exist, but those are, admittedly, both difficult to fix and not too important. I've pointed out where such FNs/FPs are possible, but I don't necessarily expect any changes there - some refinements would be nice to have, but only if you think that some of them would be easily fixed.

@guillaume-dequenne guillaume-dequenne force-pushed the SONARPY-663 branch 2 times, most recently from 20404f7 to 6c7fc94 Compare May 13, 2020 08:25
@sonarsource-next
Copy link

sonarsource-next bot commented May 13, 2020

Kudos, SonarQube Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@guillaume-dequenne
Copy link
Contributor Author

guillaume-dequenne commented May 13, 2020

Nice intuition on the 100 threshold :)

I guess the worst case scenario is actually the most common scenario (granted not reflected by the unit test which would terminate early) since duplicate keys are not desirable, so I'm not sure which comment should be changed and how?

@guillaume-dequenne guillaume-dequenne merged commit cefa5ee into master May 13, 2020
@guillaume-dequenne guillaume-dequenne deleted the SONARPY-663 branch May 13, 2020 14:10
hashicorp-vault-sonar-prod bot pushed a commit that referenced this pull request Dec 15, 2025
@Seppli11
SONARPY-3575 Use QualifiedExpression for function return type (#712)
85d3d9b 
GitOrigin-RevId: 8c4f92335925cf1d2ab2be94698dde37995b78c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrey-tyukin-sonarsource andrey-tyukin-sonarsource andrey-tyukin-sonarsource left review comments

@andrea-guarino-sonarsource andrea-guarino-sonarsource Awaiting requested review from andrea-guarino-sonarsource

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guillaume-dequenne @andrea-guarino-sonarsource @andrey-tyukin-sonarsource