Skip to content

SONARPY-734 Fix memory leak in BuiltinShadowingAssignmentCheck (S5806)#787

Merged
andrea-guarino-sonarsource merged 2 commits intomasterfrom
fix-memory-leak-builtin-shadowed
Jun 17, 2020
Merged

SONARPY-734 Fix memory leak in BuiltinShadowingAssignmentCheck (S5806)#787
andrea-guarino-sonarsource merged 2 commits intomasterfrom
fix-memory-leak-builtin-shadowed

Conversation

@andrea-guarino-sonarsource
Copy link
Copy Markdown
Contributor

No description provided.

@andrea-guarino-sonarsource andrea-guarino-sonarsource changed the title Fix memory leak in BuiltinShadowingAssignmentCheck (S5806) SONARPY-734 Fix memory leak in BuiltinShadowingAssignmentCheck (S5806) Jun 17, 2020
Copy link
Copy Markdown
Contributor

@guillaume-dequenne guillaume-dequenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


@Override
public void initialize(Context context) {
variableIssuesRaised.clear();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion a clear at each visit of a FILE_INPUT would be a bit more explicit with regard to which lifespan we want for the map's content, but I don't have that strong an opinion on this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I will do that

@sonarsource-next
Copy link
Copy Markdown

Kudos, SonarQube Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@andrea-guarino-sonarsource andrea-guarino-sonarsource merged commit de4c65a into master Jun 17, 2020
@andrea-guarino-sonarsource andrea-guarino-sonarsource deleted the fix-memory-leak-builtin-shadowed branch June 17, 2020 12:25
hashicorp-vault-sonar-prod Bot pushed a commit that referenced this pull request Feb 2, 2026
Co-authored-by: Thomas Serre <thomas.serre@sonarsource.com>
Co-authored-by: Thomas Serre <118730793+thomas-serre-sonarsource@users.noreply.github.com>
GitOrigin-RevId: 66f75d4a18b185ac555442d8a1a422e3b6eb770c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants