Skip to content

Log execution time of creation of project symbol table#819

Merged
guillaume-dequenne merged 1 commit intomasterfrom
dogfood-global-symbol-table
Jul 28, 2020
Merged

Log execution time of creation of project symbol table#819
guillaume-dequenne merged 1 commit intomasterfrom
dogfood-global-symbol-table

Conversation

@guillaume-dequenne
Copy link
Copy Markdown
Contributor

No description provided.

@guillaume-dequenne guillaume-dequenne marked this pull request as ready for review July 27, 2020 15:06
@guillaume-dequenne guillaume-dequenne marked this pull request as draft July 27, 2020 15:06
@guillaume-dequenne guillaume-dequenne force-pushed the dogfood-global-symbol-table branch from 8dc57e4 to 653ea7b Compare July 27, 2020 15:07
@guillaume-dequenne guillaume-dequenne changed the title Log execution time of creation of project symbol table Do not merge (Log execution time of creation of project symbol table) Jul 28, 2020
@guillaume-dequenne guillaume-dequenne force-pushed the dogfood-global-symbol-table branch 3 times, most recently from 791836f to b528f7a Compare July 28, 2020 08:40
@guillaume-dequenne guillaume-dequenne changed the title Do not merge (Log execution time of creation of project symbol table) Log execution time of creation of project symbol table Jul 28, 2020
@guillaume-dequenne guillaume-dequenne marked this pull request as ready for review July 28, 2020 08:40
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we already have a message saying Starting global symbols computation , do we really need this?

Copy link
Copy Markdown
Contributor Author

@guillaume-dequenne guillaume-dequenne Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed we don't! I removed it.

@guillaume-dequenne guillaume-dequenne force-pushed the dogfood-global-symbol-table branch from b528f7a to d0b2a26 Compare July 28, 2020 09:37
@sonarsource-next
Copy link
Copy Markdown

Kudos, SonarQube Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@guillaume-dequenne guillaume-dequenne merged commit 9b2e534 into master Jul 28, 2020
@guillaume-dequenne guillaume-dequenne deleted the dogfood-global-symbol-table branch July 28, 2020 10:01
hashicorp-vault-sonar-prod Bot pushed a commit that referenced this pull request Feb 2, 2026
…ode (#819)

GitOrigin-RevId: 747a09fb93c42aa56d835e8469ee17c0ae1a99ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants