SONARPY-775 Fix FN on S5797: flow sensitive inference not enabled for nested try/except#827
Merged
guillaume-dequenne merged 2 commits intomasterfrom Aug 10, 2020
Merged
SONARPY-775 Fix FN on S5797: flow sensitive inference not enabled for nested try/except#827guillaume-dequenne merged 2 commits intomasterfrom
guillaume-dequenne merged 2 commits intomasterfrom
Conversation
guillaume-dequenne
force-pushed
the
SONARPY-775
branch
2 times, most recently
from
5e28e86 to
69fad5b
Compare
guillaume-dequenne
force-pushed
the
SONARPY-775
branch
3 times, most recently
from
a813bf7 to
6f13d71
Compare
guillaume-dequenne
force-pushed
the
SONARPY-775
branch
from
6f13d71 to
090d9d3
Compare
andrea-guarino-sonarsource
approved these changes
Aug 10, 2020
| functionDef.accept(new BaseTreeVisitor() { | ||
| @Override | ||
| public void visitFunctionDef(FunctionDef visited) { | ||
| if (functionDef == visited) { |
Contributor
There was a problem hiding this comment.
I think that to avoid this condition we can call the visitor on the body like functionDef.body().accept(new BaseTreeVisitor() {}) at line 107
|
|
||
| @Override | ||
| public void visitFunctionDef(FunctionDef visited) { | ||
| if (functionDef == visited) { |
Contributor
There was a problem hiding this comment.
Also here, I think we can call the visitor on the body of the function
guillaume-dequenne
force-pushed
the
SONARPY-775
branch
from
e608930 to
77f9750
Compare
|
Kudos, SonarQube Quality Gate passed! |
hashicorp-vault-sonar-prod Bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
GitOrigin-RevId: b12a8338b5faa6b2658c86f5f028dc3c09920f1e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.