SONARPY-751 S5886: Fix FPs on iterators and unknown type aliases#832
Merged
guillaume-dequenne merged 3 commits intomasterfrom Aug 12, 2020
Merged
SONARPY-751 S5886: Fix FPs on iterators and unknown type aliases#832guillaume-dequenne merged 3 commits intomasterfrom
guillaume-dequenne merged 3 commits intomasterfrom
Conversation
guillaume-dequenne
force-pushed
the
SONARPY-751b
branch
7 times, most recently
from
95b7778 to
c33cdda
Compare
guillaume-dequenne
changed the title
guillaume-dequenne
force-pushed
the
SONARPY-751b
branch
from
c33cdda to
b64bb32
Compare
guillaume-dequenne
force-pushed
the
SONARPY-751b
branch
from
b64bb32 to
e898258
Compare
| @@ -83,6 +83,9 @@ public Optional<Symbol> resolveMember(String memberName) { | |||
| @Override | |||
| public boolean canBeOrExtend(String typeName) { | |||
| if (typeName.equals("typing.Tuple") || typeName.equals("tuple")) { | |||
Contributor
There was a problem hiding this comment.
as discussed I think we shouldn't have this logic in the API. I think we can accept the FN on tuple for the time being and having a proper fix for return statement tree
guillaume-dequenne
force-pushed
the
SONARPY-751b
branch
from
4d7ab09 to
cbd1183
Compare
guillaume-dequenne
force-pushed
the
SONARPY-751b
branch
from
cbd1183 to
1402de7
Compare
|
Kudos, SonarQube Quality Gate passed! |
hashicorp-vault-sonar-prod Bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
GitOrigin-RevId: bbe07e85a8130bc46393c0b41f47935c9337c100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.