SONARPY-743 Avoid raising FP when 'isinstance' is used#839
Merged
andrea-guarino-sonarsource merged 2 commits intomasterfrom Aug 18, 2020
Merged
SONARPY-743 Avoid raising FP when 'isinstance' is used#839andrea-guarino-sonarsource merged 2 commits intomasterfrom
andrea-guarino-sonarsource merged 2 commits intomasterfrom
Conversation
andrea-guarino-sonarsource
force-pushed
the
SONARPY-743b
branch
from
752b683 to
9527d79
Compare
guillaume-dequenne
approved these changes
Aug 18, 2020
Contributor
guillaume-dequenne
left a comment
guillaume-dequenne
left a comment
There was a problem hiding this comment.
lgtm, one minor comment about test case.
Contributor
There was a problem hiding this comment.
Is that correct? Here the last x is independent from the isinstance check.
I see why we'd want to stay conservative here and have x as ANY nevertheless, but I think a test case within the if body would still be useful.
In the future when we have more confidence about isinstance checks, I could see the type of x here remain DECL_INT.
Contributor
Author
There was a problem hiding this comment.
Makes sense, I will add a test to check inside the if branch body. I think it still makes sense to keep this test, so that it will break as soon as we'll implement isinstance properly
andrea-guarino-sonarsource
force-pushed
the
SONARPY-743b
branch
from
9527d79 to
2d3d1a9
Compare
|
Kudos, SonarQube Quality Gate passed! |
hashicorp-vault-sonar-prod Bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
GitOrigin-RevId: 65258b5eea4fe2c0cc94f3e4512ee981dbd4cc4f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.