SONARPY-778 Rule S5890: Values assigned to variables should match their type annotations#847
Merged
guillaume-dequenne merged 2 commits intomasterfrom Aug 20, 2020
Merged
SONARPY-778 Rule S5890: Values assigned to variables should match their type annotations#847guillaume-dequenne merged 2 commits intomasterfrom
guillaume-dequenne merged 2 commits intomasterfrom
Conversation
guillaume-dequenne
force-pushed
the
SONARPY-778
branch
5 times, most recently
from
43919f3 to
ea8bd33
Compare
andrea-guarino-sonarsource
approved these changes
Aug 20, 2020
Contributor
andrea-guarino-sonarsource
left a comment
andrea-guarino-sonarsource
left a comment
There was a problem hiding this comment.
LGTM, please check some minor comments
Contributor
There was a problem hiding this comment.
I think we can mark it as FN, as we'll probably want to detect it when we'll implement MMF-1977
Contributor
There was a problem hiding this comment.
why did you use the fully qualified name for SubscriptionContext?
Contributor
There was a problem hiding this comment.
minor: usually we don't add the Check suffix in the python file name
guillaume-dequenne
force-pushed
the
SONARPY-778
branch
from
ea8bd33 to
7c6ddc5
Compare
guillaume-dequenne
force-pushed
the
SONARPY-778
branch
from
7c6ddc5 to
79e06ab
Compare
|
Kudos, SonarQube Quality Gate passed! |
hashicorp-vault-sonar-prod Bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
GitOrigin-RevId: 549d33f6887bc6624be25eb09e74753d09095ebb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.