SONARPY-744 Avoid FP when subscription object is used inside 'in expr…#861
Merged
andrea-guarino-sonarsource merged 1 commit intomasterfrom Aug 28, 2020
Merged
SONARPY-744 Avoid FP when subscription object is used inside 'in expr…#861andrea-guarino-sonarsource merged 1 commit intomasterfrom
andrea-guarino-sonarsource merged 1 commit intomasterfrom
Conversation
|
Kudos, SonarQube Quality Gate passed! |
guillaume-dequenne
approved these changes
Aug 28, 2020
Contributor
guillaume-dequenne
left a comment
guillaume-dequenne
left a comment
There was a problem hiding this comment.
LGTM, 1 minor comment
|
|
||
| private static boolean isRightOperandInExpression(Tree tree) { | ||
| Tree parent = tree.parent(); | ||
| if (parent instanceof InExpression) { |
Contributor
There was a problem hiding this comment.
Minor: I think you can use Tree::is here instead.
Contributor
Author
There was a problem hiding this comment.
If you don't mind, I'd prefer to use instanceof here so that it will also work in case of parent being null
hashicorp-vault-sonar-prod bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
…anguage is specified (#861) GitOrigin-RevId: 881c30a7a345a4b76abb562a5da18965e90d75f1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…essions'