Skip to content

SONARPY-827 Rule S5780 (DictionaryDuplicateKeyCheck) should not fail when comparing hex long integers #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrea-guarino-sonarsource merged 1 commit into from
Jan 25, 2021
Merged

SONARPY-827 Rule S5780 (DictionaryDuplicateKeyCheck) should not fail when comparing hex long integers #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python-checks/src/main/java/org/sonar/python/checks/AbstractDuplicateKeyCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ private static boolean areEquivalentStringLiterals(StringLiteral key, StringLite

public BigDecimal parseAsBigDecimal(String numberLiteralValue) {
String numberValue = numberLiteralValue.replace("_", "");
if (numberValue.endsWith("L") || numberValue.endsWith("l")) {
numberValue = numberValue.substring(0, numberValue.length() - 1);
}
if (numberValue.startsWith("0b") || numberValue.startsWith("0B")) {
return new BigDecimal(new BigInteger(numberValue.substring(2), 2));
}
Expand Down
4 changes: 4 additions & 0 deletions python-checks/src/test/resources/checks/dictionaryDuplicateKey.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,14 @@ def strings():
{f"one{p()}": 1, "two": 2, f"one{p()}": 3} # FN (ok)

def numbers():
{1: "one", 2: "two", 3: "three"}
{1: "one", 2: "two", 1: "three"} # Noncompliant
{1.0: "one", 2.0: "two", 3.0: "three"}
{1.0: "one", 2.0: "two", 1.0: "three"} # Noncompliant
{0o1: "one", 0o2: "two", 0O1: "three"} # Noncompliant
{0x1: "one", 0x3: "two", 0X1: "three"} # Noncompliant
{0xB1E70073L: "1", 0xB1E70073L: "1"} # Noncompliant [[only valid for python 2]]
{0xB1E70073l: "1", 0xB1E70073l: "1"} # Noncompliant [[only valid for python 2]]
{0b1: "one", 0o2: "two", 0B1: "three"} # Noncompliant
{True: "one", False: "two", True: "three"} # Noncompliant

Expand Down