SONARPY-816 S1720 should not raise on empty __init__.py

python-checks/src/main/java/org/sonar/python/checks/MissingDocstringCheck.java

@@ -54,11 +54,18 @@ private enum DeclarationType {
 
   @Override
   public void initialize(Context context) {
-    context.registerSyntaxNodeConsumer(Kind.FILE_INPUT, ctx -> checkDocString(ctx, ((FileInput) ctx.syntaxNode()).docstring()));
+    context.registerSyntaxNodeConsumer(Kind.FILE_INPUT, ctx -> checkFileInput(ctx, (FileInput) ctx.syntaxNode()));
     context.registerSyntaxNodeConsumer(Kind.FUNCDEF, ctx -> checkDocString(ctx, ((FunctionDef) ctx.syntaxNode()).docstring()));
     context.registerSyntaxNodeConsumer(Kind.CLASSDEF, ctx -> checkDocString(ctx, ((ClassDef) ctx.syntaxNode()).docstring()));
   }
 
+  private static void checkFileInput(SubscriptionContext ctx, FileInput fileInput) {
+    if ("__init__.py".equals(ctx.pythonFile().fileName()) && fileInput.statements() == null) {
+      return;
+    }
+    checkDocString(ctx, fileInput.docstring());
+  }
+
   private static void checkDocString(SubscriptionContext ctx, @CheckForNull StringLiteral docstring) {
     Tree tree = ctx.syntaxNode();
     DeclarationType type = getType(tree);

python-checks/src/test/java/org/sonar/python/checks/MissingDocstringCheckTest.java

@@ -26,17 +26,22 @@ public class MissingDocstringCheckTest {
 
   @Test
   public void test() {
-    PythonCheckVerifier.verify("src/test/resources/checks/missingDocstring.py", new MissingDocstringCheck());
+    PythonCheckVerifier.verify("src/test/resources/checks/missing_docstring/missingDocstring.py", new MissingDocstringCheck());
   }
 
   @Test
   public void testMissingDocStringAtModuleLevel() {
-    PythonCheckVerifier.verify("src/test/resources/checks/missingDocstringAtModuleLevel.py", new MissingDocstringCheck());
+    PythonCheckVerifier.verify("src/test/resources/checks/missing_docstring/missingDocstringAtModuleLevel.py", new MissingDocstringCheck());
   }
 
   @Test
   public void testEmptyModule() {
-    PythonCheckVerifier.verify("src/test/resources/checks/emptyModule.py", new MissingDocstringCheck());
+    PythonCheckVerifier.verify("src/test/resources/checks/missing_docstring/emptyModule.py", new MissingDocstringCheck());
   }
 
+  @Test
+  public void __init__without_docstring() {
+    PythonCheckVerifier.verifyNoIssue("src/test/resources/checks/missing_docstring/empty_init/__init__.py", new MissingDocstringCheck());
+    PythonCheckVerifier.verify("src/test/resources/checks/missing_docstring/nonempty_init/__init__.py", new MissingDocstringCheck());
+  }
 }

python-checks/src/test/resources/checks/missing_docstring/nonempty_init/__init__.py

@@ -0,0 +1,2 @@
+#Noncompliant@-1 {{Add a docstring to this module.}}
+print("hello!")