SONARPY-819 Update Typeshed to support Python 3.9#881
Merged
Conversation
|
Kudos, SonarQube Quality Gate passed! |
hashicorp-vault-sonar-prod Bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
GitOrigin-RevId: 7248309c6bfbfc1f6f7995e2dcdeac65d622a484
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typeshed maintenairs decided to split
2and3/builtins.pyiinto2/builtins.pyiand3/builtins.pyi.This change has quite a few consequences on sonar-python, because we don't currently have a simple way to merge python2 and python3 symbols with the same fully qualified name (we rely instead on creating a wrapper symbol, named AmbigousSymbol).
In order to avoid having many AmbigousSymbols for builtins (like str or int), I decided to copy latest version of
2and3/builtins.pyiand let sonar-python rely on it.I created SONARPY-830 to remove this copied version and use instead latest
2/builtins.pyiand3/builtins.pyi.