Skip to content

SCANPY-245 Fix strict dependencies pinning of pysonar#312

Merged
guillaume-dequenne merged 5 commits intomasterfrom
strict-dependencies-pinning
Apr 1, 2026
Merged

SCANPY-245 Fix strict dependencies pinning of pysonar#312
guillaume-dequenne merged 5 commits intomasterfrom
strict-dependencies-pinning

Conversation

@guillaume-dequenne
Copy link
Copy Markdown
Contributor

No description provided.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Fix strict dependencies pinning of pysonar SCANPY-245 Fix strict dependencies pinning of pysonar Mar 30, 2026
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod bot commented Mar 30, 2026

SCANPY-245

@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha bot commented Mar 30, 2026

Summary

DEPENDENCY MANAGEMENT OVERHAUL. You've taken the rigid exact-pinning approach—every ingredient measured to the nanogram—and loosened it sensibly. Tomli, requests, and jproperties now float within semantic version ranges: >=2.0,<3, >=2.32,<3, >=2.1,<3 respectively. Test-only noise—responses and pyfakefs—yanked out of the main dependencies and relegated to dev where they belong. You also corrected a naming blunder: jfrog-server source renamed to repox. Result: a poetry.lock regeneration with 1247 lines of locked dependency states, reflecting cleaner ingredient sourcing. The application code itself is pristine—untouched. This is plumbing work done properly.

What reviewers should know

Start here: Ignore the poetry.lock mammoth—it's a mechanical consequence of loosening version constraints. Focus on pyproject.toml diffs. What changed: Three core dependencies relaxed from exact versions (e.g., 2.2.1) to safe ranges (e.g., >=2.0,<3), allowing patch and minor updates without forcing major version rewrites. Responses and pyfakefs properly exiled to dev dependencies—they're test infrastructure, not runtime requirements. Source reference renamed for clarity. Why it matters: Exact pinning is kitchen-prep laziness dressed as rigor. Sensible ranges (>=X,<MAJOR+1) preserve stability while allowing security patches and minor improvements through the supply chain without manual intervention. No gotchas: The source name change is cosmetic but necessary. Workflow files and CI config additions are supplementary infrastructure—they enable this dependency strategy. All ingredient measurements are sound.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback


  • 🐟 April Fools' persona mode!

@guillaume-dequenne guillaume-dequenne force-pushed the strict-dependencies-pinning branch from 0c2ee3c to feca753 Compare March 30, 2026 15:26
Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conclusion: The dependency changes are correct in intent — loosening pins for runtime deps and moving test libraries to dev. One question needs clarification before approving.

🗣️ Give feedback

Comment thread poetry.lock Outdated
@@ -1,4 +1,4 @@
# This file is automatically @generated by Poetry 2.3.2 and should not be changed by hand.
# This file is automatically @generated by Poetry 2.1.1 and should not be changed by hand.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lock file was generated with Poetry 2.1.1, but the previous lock file was generated with 2.3.2. This is a downgrade. The mise toolchain in this repo pins specific tool versions — was this intentional? If CI or other developers run a different Poetry version (2.3.x), they may get a different lock file on next poetry lock, causing churn. Please confirm this matches the Poetry version pinned in .mise.toml / .tool-versions.

  • Mark as noise

@guillaume-dequenne guillaume-dequenne force-pushed the strict-dependencies-pinning branch from feca753 to dfd3758 Compare March 31, 2026 09:28
sonar-review-alpha[bot]

This comment was marked as outdated.

sonar-review-alpha[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@joke1196 joke1196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you need to add pygments 2.19, was version 2.20 not available?

sonar-review-alpha[bot]

This comment was marked as outdated.

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

@guillaume-dequenne guillaume-dequenne force-pushed the strict-dependencies-pinning branch from d09e3a3 to 5d5cbb1 Compare April 1, 2026 08:40
@sonarqube-next
Copy link
Copy Markdown

sonarqube-next bot commented Apr 1, 2026

Quality Gate passed Quality Gate passed for 'Python Scanner'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@guillaume-dequenne guillaume-dequenne merged commit 9390302 into master Apr 1, 2026
17 of 18 checks passed
@guillaume-dequenne guillaume-dequenne deleted the strict-dependencies-pinning branch April 1, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants