Avoid CAKE_CORE_INCLUDE_PATH multiple definition#365
Merged
lGuillaume124 merged 2 commits intoSonerezh:masterfrom Feb 6, 2019
Merged
Avoid CAKE_CORE_INCLUDE_PATH multiple definition#365lGuillaume124 merged 2 commits intoSonerezh:masterfrom
lGuillaume124 merged 2 commits intoSonerezh:masterfrom
Conversation
Sync 1.2.5
Related to Sonerezh#357 title. As CAKE_CORE_INCLUDE_PATH is set by top level index.php, defining the constant without checking it is already defined triggers PHP notice `PHP Notice: Constant CAKE_CORE_INCLUDE_PATH already defined.
Nizhile
added a commit
to Nizhile/sonerezh
that referenced
this pull request
Feb 7, 2019
Merge pull request Sonerezh#365 from Nizhile/master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making diffs with new 1.2.5 release shows that I forget this one to avoid #357 php notice. Sonerezh will work correctly without it, but will trigger some logs stating that
CAKE_CORE_INCLUDE_PATHis already defined.