security: HTML-encode user input in renderAlert to prevent reflected XSS#714
Merged
security: HTML-encode user input in renderAlert to prevent reflected XSS#714
Conversation
Fixes #711 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lane711
added a commit
that referenced
this pull request
Mar 30, 2026
Security hardening release: - SQL injection fix via sort order validation (#713) - Reflected XSS fix on auth pages (#714) - Stored XSS fix in content preview (#715) - Security headers middleware (#708) - Auth endpoint rate limiting (#707) - CORS restrictions (#706) - PBKDF2 password hashing (#705) - JWT secret to environment variable (#704) Bug fixes: - Radio field support (#723) - Confirm dialogs for repeater/block deletes (#722) - Rich text editor field types (#721) - user_profiles migration in core (#718) - itemTitle for structured arrays (#725) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes reflected XSS vulnerability on
/auth/loginand/auth/registerpages via theerrorquery parameter.No authentication required to exploit.
Changes
packages/core/src/templates/alert.template.ts— AppliedescapeHtml()todata.messageanddata.titlebefore HTML interpolationpackages/core/src/templates/components/alert.template.ts— Same fix (duplicate template file)packages/core/src/__tests__/templates/alert-xss.test.ts— 7 new tests verifying XSS payloads are properly encodedTesting
Credit
Vulnerability reported by Zhengyu Wang
Fixes #711
🤖 Generated with Claude Code