This repository was archived by the owner on Nov 13, 2024. It is now read-only.
fix: Config.bodycamOverlayEnabled and Config.bodycamEnabled #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fireant456
approved these changes
Mar 15, 2024
Contributor
Fireant456
left a comment
Fireant456
left a comment
There was a problem hiding this comment.
Looks great, I don't see any issues on my end
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these settings had no effect. This PR should prevent the commands being registered, and events enabling/disabling the bodycam, and display of the overlay as expected when the appropriate Config value is changed.
Resolves issue #89