chore(e2e): switch iOS E2E to Maestro and stabilize manual workflow#123
Merged
chore(e2e): switch iOS E2E to Maestro and stabilize manual workflow#123
Conversation
Problem: The e2e-manual iOS job failed in Setup Ruby because Ruby 3.2 is incompatible with Bundler 1.17.2 ( NoMethodError). Solution: Downgraded the iOS workflow Ruby version to 3.1 in to match the Gemfile.lock Bundler version.
Problem: The Android e2e step failed with /usr/bin/sh: 1: Syntax error: end of file unexpected (expecting fi) when running the multiline script in android-emulator-runner. Solution: Replaced the multiline conditional script with a single-line if ...; then ...; else ...; fi command in .github/workflows/e2e-manual.yml to avoid shell parsing issues in the action wrapper.
Problem: E2E failed because maestro-runner was added to the wrong PATH location, and iOS runs had no explicit Team ID in CI. Solution: Updated GITHUB_PATH to ~/.maestro-runner/bin for both jobs and added workflow_dispatch input ios_team_id mapped to MAESTRO_IOS_TEAM_ID in iOS E2E step.,
Problem: iOS E2E required WDA signing through maestro-runner, which is not feasible on hosted CI environments without Apple account credentials and signing assets. Solution: Run iOS flows with Maestro CLI and keep Android on maestro-runner. Updated e2e runner branching logic, workflow install steps, and docs to match this split.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR switches iOS E2E execution from
maestro-runnertoMaestro CLIand stabilizes/tunes the manual E2E workflow.Changes
Key updates:
e2e/run.ts.maestromaestro-runner--team-idoption and iOS team-id resolution logic.3.1maestro-runnerPATH120minutes20minutes