Remove check for rails-controller-testing gem #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rails-controller-testing` gem provided helper methods for controller tests up to Rails 4.2. This condition was used to support testing with both Rails 4.2 and Rails 5+. Since we no longer test with Rails versions below 5, the condition is no longer necessary. ref: Sorcery#21
joshbuker
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rails-controller-testinggem provided helper methods for controller tests up to Rails 4.2. This condition was used to support testing with both Rails 4.2 and Rails 5+. Since we no longer test with Rails versions below 5, the condition is no longer necessary.ref: #21