Refactor the part that loads submodules #402
Merged
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the approach so constants can be safely loaded even when a configured submodule doesn’t exist, without raising a NameError
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the submodule loading mechanism in lib/sorcery/controller.rb to use a more explicit constant checking approach instead of relying on exception handling for missing submodules.
Key changes:
- Replaced try-catch exception handling with a proactive
const_defined?check before attempting to load submodules - Extracted the submodule name transformation into a separate variable for improved readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Right now, Submodules doesn’t inherit anything, but to prevent unintended includes if Submodules is changed in the future, I explicitly made sure that constants from Submodules’ ancestors are not included. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
joshbuker
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the approach so constants can be safely loaded even when a configured submodule doesn’t exist, without raising a NameError