Skip to content

Refactor the part that loads submodules #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
+2 −4
Merged

Refactor the part that loads submodules #402

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8f177b
Refactor the part that loads submodules
willnet Nov 11, 2025
f4b447d
Do not include constants from Submodules' ancestors
willnet Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/sorcery/controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,8 @@ def self.included(klass)
include InstanceMethods

Config.submodules.each do |mod|
# FIXME: Is there a cleaner way to handle missing submodules?
include Submodules.const_get(mod.to_s.split('_').map(&:capitalize).join) # rubocop:disable Layout/EmptyLinesAfterModuleInclusion
rescue NameError
# don't stop on a missing submodule.
submodule_name = mod.to_s.split('_').map(&:capitalize).join
include Submodules.const_get(submodule_name) if Submodules.const_defined?(submodule_name, false)
end
end
Config.update!
Expand Down