NetworkBanner/NetworkScreen fixes for #170#238
Merged
k-deejah merged 1 commit intoJun 30, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #170 reported three problems in
NetworkBannerandNetworkScreen:InfoCellvalues (passphrase, RPC URL, Horizon URL) had no copy mechanismAll three fixes were already implemented and merged to
mainin commitscddfe68,3b9b7c5, andd7064cd, but the change was never recorded inCHANGELOG.mdand the issue was left open without a closing reference.This PR closes that gap by adding a
### Fixedentry under[Unreleased]documenting the change, and closes the issue.
Changes
CHANGELOG.md### Fixedsubsection under## [Unreleased]documenting:NetworkBannersuppression on the Network screenInfoCellstransition-all duration-300fade onNetworkBannernetwork switchVerification
git diff main -- src/components/NetworkBanner.tsx src/screens/NetworkScreen.tsxthat all three fixes already exist onmain:NetworkBanner.tsx:if (active === "network") return null;andtransition-all duration-300on the rootdivNetworkScreen.tsx:copyableprop wired to Passphrase, RPC URL, and Horizon URLInfoCells, using the same copy-icon pattern asAddressDisplaynpm run buildpassesCloses #170