Fix navigation error from SecuritySettingsScreen to AuthenticationScreen#862
Merged
SorrowBlue merged 4 commits intomainfrom Sep 3, 2025
Merged
Fix navigation error from SecuritySettingsScreen to AuthenticationScreen#862SorrowBlue merged 4 commits intomainfrom
SorrowBlue merged 4 commits intomainfrom
Conversation
…ation issue Co-authored-by: SorrowBlue <25735189+SorrowBlue@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Error when navigating from SecuritySettingsScreen to AuthenticationScreen
Fix navigation error from SecuritySettingsScreen to AuthenticationScreen
Sep 2, 2025
…phNavigator and related interfaces
SorrowBlue
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a navigation error that occurred when trying to navigate from SecuritySettingsScreen to AuthenticationScreen. The error was:
Root Cause
The issue was caused by a navigation scope mismatch in the dependency injection setup:
SecuritySettingsresides inSettingsDetailNavGraphAuthenticationwas defined in the parentSettingsNavGraphSolution
Moved the
Authenticationdestination fromSettingsNavGraphtoSettingsDetailNavGraphwhereSecuritySettingsresides. This ensures that:Changes
Authenticationas a destination and updatedSettingsDetailNavGraphNavigatorto handle authentication navigation directlyAuthenticationdestination to avoid duplicationThe changes are minimal and focused, maintaining the existing architecture while fixing the navigation scope issue.
Fixes #861.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/rate_limitREDACTED, pid is -1(http block)spdx.orgIf you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.