♻️ Improve UI and dependency injection redundant.#887
Conversation
SorrowBlue
added
the
type: ♻️refactor
github-actions
Bot
added
the
type: ✨feature
SorrowBlue
removed
the
type: ✨feature
There was a problem hiding this comment.
Pull Request Overview
This PR improves UI components and addresses dependency injection redundancy in the ComicViewer Kotlin Multiplatform project. The changes focus on upgrading Compose UI dependencies, streamlining dependency injection patterns, and removing redundant code.
Key Changes:
- Updated Compose UI libraries and Android dependencies to newer versions
- Unified dependency injection patterns by removing redundant expect/actual declarations
- Removed deprecated shared element animations and simplified UI transition code
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updated dependency versions for Compose UI, Core Splashscreen, and Navigation Compose |
| framework/ui/src/commonMain/kotlin/com/sorrowblue/comicviewer/framework/ui/NotificationManager.kt | Added PlatformContext parameter to expect class declaration |
| framework/ui/src/androidMain/kotlin/com/sorrowblue/comicviewer/framework/ui/NotificationManager.android.kt | Updated to use PlatformContext instead of Android Context |
| framework/ui/src/iosMain/kotlin/com/sorrowblue/comicviewer/framework/ui/NotificationManager.ios.kt | Added PlatformContext constructor parameter |
| framework/ui/src/desktopMain/kotlin/com/sorrowblue/comicviewer/framework/ui/NotificationManager.desktop.kt | Added PlatformContext constructor parameter |
| framework/ui/src/commonMain/kotlin/com/sorrowblue/comicviewer/framework/ui/canonical/PrimaryActionButton.kt | Removed shared element animations and improved FAB configuration |
| framework/ui/src/commonMain/kotlin/com/sorrowblue/comicviewer/framework/ui/animation/Transition.kt | Simplified transition animations by removing custom timing specifications |
| data/storage/device/src/commonMain/kotlin/com/sorrowblue/comicviewer/data/storage/device/impl/DeviceFileClient.kt | Removed expect class declaration (moved implementation to platform-specific files) |
| data/storage/device/src/androidMain/kotlin/com/sorrowblue/comicviewer/data/storage/device/impl/DeviceFileClient.android.kt | Removed actual keyword from class declaration |
| composeApp/src/commonMain/kotlin/com/sorrowblue/comicviewer/app/AppModule.kt | Updated Koin module configuration with new annotations |
| }, | ||
| content = content, | ||
| modifier = modifier | ||
| // TODO FloatingActionButtonMenuの余分なPadding対策 |
There was a problem hiding this comment.
The TODO comment is in Japanese. According to the coding standards, comments should be in English for consistency and maintainability in a multilingual development environment.
| // TODO FloatingActionButtonMenuの余分なPadding対策 | |
| // TODO: Address the extra padding in FloatingActionButtonMenu |
| easing = LinearOutSlowInEasing, | ||
| ), | ||
| ) | ||
| // + materialFadeThroughIn() |
There was a problem hiding this comment.
These commented-out code lines should either be removed if they're no longer needed or replaced with proper TODO comments if they represent future functionality. Leaving commented code without explanation reduces code clarity.
| easing = FastOutLinearInEasing, | ||
| ), | ||
| ) | ||
| // + materialFadeThroughOut() |
There was a problem hiding this comment.
These commented-out code lines should either be removed if they're no longer needed or replaced with proper TODO comments if they represent future functionality. Leaving commented code without explanation reduces code clarity.
| easing = LinearOutSlowInEasing, | ||
| ), | ||
| ) | ||
| // + materialFadeThroughIn() |
There was a problem hiding this comment.
These commented-out code lines should either be removed if they're no longer needed or replaced with proper TODO comments if they represent future functionality. Leaving commented code without explanation reduces code clarity.
| easing = FastOutLinearInEasing, | ||
| ), | ||
| ) | ||
| // + materialFadeThroughOut() |
There was a problem hiding this comment.
These commented-out code lines should either be removed if they're no longer needed or replaced with proper TODO comments if they represent future functionality. Leaving commented code without explanation reduces code clarity.
github-actions
Bot
added
the
type: ✨feature
SorrowBlue
deleted the
feature/886-improve-ui-and-dependency-injection-redundant
branch
SorrowBlue
removed
the
type: ✨feature
Fixes #886