Updated onTapStart Handler to not bubble avoiding errors with nested sortables#328
Closed
cef62 wants to merge 1 commit into
Closed
Updated onTapStart Handler to not bubble avoiding errors with nested sortables#328cef62 wants to merge 1 commit into
cef62 wants to merge 1 commit into
Conversation
Stopping event propagation avoid wrong indexes for starting position with nested sortables. Related SortableJS#152 and SortableJS#318
Collaborator
|
This will not work in IE < 10. And in general the wrong approach. |
RubaXa
added a commit
that referenced
this pull request
Apr 9, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopping event propagation avoids wrong indexes for starting position
with nested sortables.
Without this fix when an element inside a nested sortable is dragged the event
oldIndexwill refer to the index of the most outer sortable instead of the starting index of the dragged item.Related #152 and
#318