Skip to content

FU-P7-T3-1: Prioritize foreign port-owner guidance in mixed broker/dashboard conflicts#160

Merged
SoundBlaster merged 8 commits into
mainfrom
codex/fu-p7-t3-1-foreign-port-owner-guidance
Mar 7, 2026
Merged

FU-P7-T3-1: Prioritize foreign port-owner guidance in mixed broker/dashboard conflicts#160
SoundBlaster merged 8 commits into
mainfrom
codex/fu-p7-t3-1-foreign-port-owner-guidance

Conversation

@SoundBlaster
Copy link
Copy Markdown
Owner

Description

Implements FU-P7-T3-1 by surfacing foreign dashboard-port owners in mixed broker/dashboard conflicts across startup and doctor, and adds regression coverage for those paths.

Validation run locally:

  • pytest tests/unit/test_main.py tests/unit/test_doctor.py -k 'mixed_state_mentions_foreign_listener or mixed_broker_and_foreign_listener_prefers_port_conflict'
  • pytest tests/unit/test_main.py tests/unit/test_doctor.py
  • pytest
  • ruff check src/
  • mypy src/
  • pytest --cov (91.64%)

Review follow-up:

  • Added FU-P7-T3-2 to SPECS/Workplan.md for the broker-owned-listener edge case discovered during review.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • CI/CD improvement

Quality Gates

Before submitting, ensure all quality gates pass:

make check

Or run individually:

  • make test - All tests pass with ≥90% coverage
  • make lint - No linting errors
  • make format - Code is properly formatted
  • make typecheck - Type checking passes
  • make doccheck - Documentation is synced with DocC (if docs changed)

Documentation Sync

If you modified files in docs/, ensure corresponding DocC files are also updated:

docs/ file DocC file
docs/installation.md mcpbridge-wrapper.docc/Installation.md
docs/cursor-setup.md mcpbridge-wrapper.docc/CursorSetup.md
docs/claude-setup.md mcpbridge-wrapper.docc/ClaudeCodeSetup.md
docs/codex-setup.md mcpbridge-wrapper.docc/CodexCLISetup.md
docs/troubleshooting.md mcpbridge-wrapper.docc/Troubleshooting.md
docs/architecture.md mcpbridge-wrapper.docc/Architecture.md
docs/environment-variables.md mcpbridge-wrapper.docc/EnvironmentVariables.md
README.md mcpbridge-wrapper.docc/mcpbridge-wrapper.md
  • Documentation changes are synced with DocC catalog (or N/A)

Testing

  • Added/updated tests for new functionality
  • All tests pass locally
  • Manually tested the changes

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • Comments added for complex code
  • Documentation updated (if needed)
  • No new warnings generated
  • PR title is descriptive

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@SoundBlaster SoundBlaster merged commit fbf13f3 into main Mar 7, 2026
10 checks passed
@SoundBlaster SoundBlaster deleted the codex/fu-p7-t3-1-foreign-port-owner-guidance branch March 7, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant