feat(studies-ui): restore lost Trials + Convergence list columns #438
+306
−9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| // SPDX-FileCopyrightText: 2026 soundminds.ai | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| /** | ||
| * Tests for the studies-list Trials + Convergence columns | ||
| * (feat_studies_convergence_visibility Story 1.2 / FR-4). | ||
| * | ||
| * Verifies: | ||
| * - the trial_count cell renders the numeric count; | ||
| * - the convergence badge renders the correct compact label/variant for | ||
| * each verdict, sourced from CONVERGENCE_VERDICT_VALUES; | ||
| * - a null verdict renders an em-dash (no badge), matching the detail | ||
| * panel's null-state behavior. | ||
| */ | ||
| import { render, screen } from '@testing-library/react'; | ||
| import { type ReactNode } from 'react'; | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| import { studiesColumns } from '@/components/studies/studies-table.column-config'; | ||
| import { TooltipProvider } from '@/components/ui/tooltip'; | ||
| import type { StudySummary } from '@/lib/api/studies'; | ||
| import { CONVERGENCE_VERDICT_VALUES } from '@/lib/enums'; | ||
|
|
||
| function baseStudy(overrides: Partial<StudySummary>): StudySummary { | ||
| return { | ||
| id: 'study-1', | ||
| name: 'demo', | ||
| cluster_id: 'c1', | ||
| status: 'completed', | ||
| best_metric: 0.8, | ||
| direction: 'maximize', | ||
| created_at: '2026-05-29T00:00:00Z', | ||
| completed_at: '2026-05-29T00:05:00Z', | ||
| trial_count: 50, | ||
| convergence_verdict: null, | ||
| ...overrides, | ||
| }; | ||
| } | ||
|
|
||
| function renderCell(columnId: string, original: StudySummary) { | ||
| const column = studiesColumns.find((c) => c.id === columnId); | ||
| if (!column?.cell || typeof column.cell !== 'function') { | ||
| throw new Error(`${columnId} column or its cell renderer not found`); | ||
| } | ||
| const cell = column.cell as (ctx: { row: { original: StudySummary } }) => ReactNode; | ||
| return render(<TooltipProvider delayDuration={0}>{cell({ row: { original } })}</TooltipProvider>); | ||
| } | ||
|
|
||
| describe('studies-table Trials column', () => { | ||
| it('renders the non-baseline trial count', () => { | ||
| renderCell('trial_count', baseStudy({ trial_count: 37 })); | ||
| expect(screen.getByText('37')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('renders zero for a queued study', () => { | ||
| renderCell('trial_count', baseStudy({ status: 'queued', trial_count: 0 })); | ||
| expect(screen.getByText('0')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('studies-table Convergence column', () => { | ||
| const cases: Array<[StudySummary['convergence_verdict'], string]> = [ | ||
| ['converged', 'Converged'], | ||
| ['still_improving', 'Improving'], | ||
| ['too_few_trials', 'Too few trials'], | ||
| ]; | ||
|
|
||
| it.each(cases)('renders the %s verdict as "%s"', (verdict, label) => { | ||
| const { container } = renderCell( | ||
| 'convergence_verdict', | ||
| baseStudy({ convergence_verdict: verdict }), | ||
| ); | ||
| expect(screen.getByText(label)).toBeInTheDocument(); | ||
| // The data-verdict attribute carries the wire value for downstream | ||
| // assertions / E2E hooks. | ||
| expect(container.querySelector(`[data-verdict="${verdict}"]`)).not.toBeNull(); | ||
| }); | ||
|
|
||
| it('renders an em-dash for a null verdict (no badge)', () => { | ||
| const { container } = renderCell( | ||
| 'convergence_verdict', | ||
| baseStudy({ convergence_verdict: null }), | ||
| ); | ||
| expect(screen.getByText('—')).toBeInTheDocument(); | ||
| expect(container.querySelector('[data-verdict]')).toBeNull(); | ||
| }); | ||
|
|
||
| it('has a label for every backend verdict literal (no missing badge)', () => { | ||
| // Source-of-truth guard: every value in CONVERGENCE_VERDICT_VALUES must | ||
| // render a non-em-dash badge. A backend verdict added without a label | ||
| // here would slip through TypeScript only if the `satisfies` map drifted; | ||
| // this is the runtime backstop. | ||
| for (const verdict of CONVERGENCE_VERDICT_VALUES) { | ||
| const { container, unmount } = renderCell( | ||
| 'convergence_verdict', | ||
| baseStudy({ convergence_verdict: verdict }), | ||
| ); | ||
| expect(container.querySelector(`[data-verdict="${verdict}"]`)).not.toBeNull(); | ||
| unmount(); | ||
| } | ||
| }); | ||
|
|
||
| it('falls back to an em-dash for an unmapped verdict (forward-compat guard)', () => { | ||
| // Regression test for the Gemini PR #438 finding (accepted): a newer | ||
| // backend could emit a convergence_verdict this frontend snapshot doesn't | ||
| // map (rolling deploy). The cast simulates that out-of-union runtime value | ||
| // — TypeScript would never let it through the typed path, but the wire can. | ||
| // The cell must render the same em-dash as the null state, NOT crash on | ||
| // `badge.variant`. | ||
| const unknown = 'diverged' as StudySummary['convergence_verdict']; | ||
| const { container } = renderCell( | ||
| 'convergence_verdict', | ||
| baseStudy({ convergence_verdict: unknown }), | ||
| ); | ||
| expect(screen.getByText('—')).toBeInTheDocument(); | ||
| // No badge rendered for the unmapped value. | ||
| expect(container.querySelector('[data-verdict]')).toBeNull(); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| // SPDX-FileCopyrightText: 2026 soundminds.ai | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| /** | ||
| * E2E spec: /studies Trials + Convergence columns | ||
| * (feat_studies_convergence_visibility Story 1.2 / FR-4, AC-6). | ||
| * | ||
| * Runs against the real `make up` stack via the helpers in `./helpers/seed.ts`. | ||
| * No `page.route()` mocking per CLAUDE.md E2E rule — the columns are driven | ||
| * by the real backend's trial_count + convergence_verdict fields. | ||
| * | ||
| * A freshly seeded study runs only a handful of trials (well below the | ||
| * 50-trial warmup floor), so its convergence verdict is either | ||
| * "Too few trials" or null (em-dash) — both are valid renderings. The | ||
| * stable, deterministic assertions are therefore: | ||
| * - the "Trials" + "Convergence" column headers render; | ||
| * - the seeded study's row shows a numeric Trials cell; | ||
| * - the Convergence cell renders either a verdict badge or the em-dash | ||
| * null-state (never crashes / never blank). | ||
| */ | ||
| import { expect, test } from '@playwright/test'; | ||
|
|
||
| import { seedFullChain, seedStudy } from './helpers/seed'; | ||
|
|
||
| test.describe('/studies convergence columns', () => { | ||
| test('Trials + Convergence columns render against the real backend', async ({ page }) => { | ||
| const chain = await seedFullChain(2); | ||
| const study = await seedStudy({ | ||
| clusterId: chain.clusterId, | ||
| querySetId: chain.querySetId, | ||
| templateId: chain.templateId, | ||
| judgmentListId: chain.judgmentListId, | ||
| maxTrials: 3, | ||
| }); | ||
|
|
||
| await page.goto('/studies'); | ||
| await expect(page.getByTestId('studies-table')).toBeVisible({ timeout: 5_000 }); | ||
|
|
||
| // Both new column headers are present. | ||
| await expect( | ||
| page.getByTestId('studies-table').getByRole('columnheader', { name: /Trials/ }), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| page.getByTestId('studies-table').getByRole('columnheader', { name: /Convergence/ }), | ||
| ).toBeVisible(); | ||
|
|
||
| // Locate the seeded study's row and assert its Trials cell is numeric. | ||
| // Filter the list to the seeded study so its row is reliably on the first | ||
| // page regardless of how many other studies exist. | ||
| const suffix = study.name.replace(/^e2e-study-/, ''); | ||
| await page.getByTestId('data-table-search').fill(suffix); | ||
| await expect( | ||
| page.getByTestId('studies-table').getByText(study.name).first(), | ||
| ).toBeVisible({ timeout: 15_000 }); | ||
|
|
||
| const row = page.locator(`[data-testid="study-row-${study.id}"]`); | ||
| await expect(row).toBeVisible(); | ||
| // The Trials cell shows a non-negative integer (tabular-nums span). | ||
| await expect(row.getByText(/^\d+$/).first()).toBeVisible(); | ||
|
|
||
| // The Convergence cell renders either a verdict badge OR the em-dash | ||
| // null-state — both are correct for a low-trial study. Assert the cell | ||
| // is non-empty (not blank/undefined). | ||
| const convergenceBadge = row.locator('[data-verdict]'); | ||
| const emDash = row.getByText('—'); | ||
| await expect(convergenceBadge.or(emDash).first()).toBeVisible(); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import
ReactNodefrom'react'to type-safe the cell renderer return type and avoid referencing the globalReactnamespace.