feat(proposals): full parameter-space panel on /proposals/[id] (feat_proposal_full_param_space_view)

[SoundMindsAI]

Summary

Adds a Full parameter space panel to the proposal detail page that shows every parameter the proposal's template declares, partitioned into three visually distinct groups so operators can see what the optimizer left on the table, not just what it changed:

• Tuned (changed by this proposal) — keys in config_diff, with the from→to delta.
• Tuned (unchanged) — in the study's search_space.params but not in config_diff (considered, not moved).
• Not in search space — declared on the template but absent from this study's tuning surface.

Now that the overnight autopilot swaps templates and tunes different knobs automatically, the proposal page IS the morning artifact operators read; this panel makes that artifact self-explanatory.

Backend: none. Migration: none. Audit events: none (read-only UI). The feature derives everything client-side from data already on the page (ProposalDetail.config_diff, ProposalDetail.template.id, StudyDetail.search_space.params, QueryTemplateDetail.declared_params).

Stories

• 1.1 — Promote extractFromTo + renderValue from config-diff-panel.tsx to a shared ui/src/lib/config-diff.ts (so both panels reuse one canonical normalizer; <ConfigDiffPanel> rendering byte-identical).
• 1.2 — Pure helper partitionTemplateParams (ui/src/lib/proposal-param-space.ts) — the partition algorithm, fully unit-tested.
• 1.3 — <FullParamSpacePanel> component + new proposal.full_param_space glossary key.
• 1.4 — Page-level integration: lift BOTH useTemplate (now sourced from proposal.template.id) AND useStudy (drop the hasActionableFollowup gate) so the panel has its data for every proposal shape, with race-aware mount gating.

Key decisions

• Partition universe = declaredParams ∪ configDiff (D-9); searchSpace-only drift keys are silently dropped (no type-tag to show).
• config_diff membership = "tuned" (D-10) — a from === to anomaly still classifies as tuned, matching <ConfigDiffPanel>'s existing semantics.
• Race-aware mount (FR-4): for study-backed proposals the panel waits for parentStudy to settle so the tunedUnchanged group never flashes a transient mis-classification.
• Caps 2 (cross-panel param linking) + 3 (study-detail mount) explicitly deferred without phase*_idea.md artifacts (D-14).

Test coverage

• Unit (15): config-diff.test.ts (7) + proposal-param-space.test.ts (8) — partition universe, drift, from===to, sort stability, legacy 2-tuple.
• Component (7): full-param-space-panel.test.tsx — three groups + counts, empty state, tooltip hover, visual states.
• Page (6 new, 18 total): lifted-fetch happy path, manual proposal, template-404 (panel absent + PrPanel stays), dual-deferred race-gating, FR-3 regression guard (no-actionable-followups digest → study still fetched), FR-7 edge-A (study fetch error).
• E2E (1 new, 5 total): real-backend Playwright asserting the panel renders for a seeded manual proposal — verified against a rebuilt production container.
• Full UI suite: 1143/1143 vitest green; tsc + next build clean.

Cross-model review: GPT-5.5 converged at spec (3 cycles) + plan (3 cycles) + phase-gate code review (4 findings accepted, 1 rejected with cited counter-evidence).

Note for reviewers

The FR-3 lift makes useStudy/useTemplate fire for every study-backed proposal, so the existing 12 page tests now trigger those secondary fetches. They pass deterministically (the queries cancel on unmount before MSW's onUnhandledRequest: 'error' fires; vitest does not fail on console.error). Verified stable across the full 1143-test suite — flagged here for transparency, not a regression.

Test plan

• pnpm test (1143 passed)
• pnpm typecheck + pnpm build
• pnpm lint (0 errors)
• Playwright proposals.spec.ts (5 passed, real backend, rebuilt container)
• Guide 02 screenshots regenerated against the running stack

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request introduces the 'Proposal Full-Parameter-Space View' feature, adding a new component to the proposal detail page. This panel displays all parameters declared by a template, partitioned into three groups: tuned and changed, tuned but unchanged, and not in the search space. To support this, the extractFromTo and renderValue helpers were promoted to a shared module, and the useTemplate and useStudy queries were refactored to load unconditionally for all proposals. The review feedback highlights two key improvements: first, a critical fix to prevent a potential runtime TypeError by ensuring searchSpaceParams is truthy before using the in operator; second, a layout enhancement suggesting a CSS grid instead of a flex layout to align the columns in the tuned-changed rows for better readability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Using the in operator on searchSpaceParams when it is null will throw a TypeError: Cannot use 'in' operator to search for '...' in null. In JavaScript/TypeScript, null !== undefined evaluates to true, so the check searchSpaceParams !== undefined does not guard against null values. Since searchSpaceParams can be null at runtime (e.g., if the API returns null for params or if the search space is empty), we should use a truthiness check instead to prevent potential runtime crashes.

Suggested change

	if (searchSpaceParams !== undefined && key in searchSpaceParams) {
	if (searchSpaceParams && key in searchSpaceParams) {

[gemini-code-assist]

The TunedChangedRows component renders the parameter names, types, and from/to values using a simple flex layout with gap-2. Because parameter names and types have varying lengths, the "from" and "to" values will not align vertically across different rows. Using a CSS grid layout (similar to a table) would align these columns perfectly, improving readability and maintaining visual consistency with the <ConfigDiffPanel> component.

Suggested change

	function TunedChangedRows({ rows }: { rows: TunedChangedRow[] }) {
	return (
	<ul className="mt-1 space-y-0.5">
	{rows.map((row) => (
	<li
	key={row.name}
	data-testid={`param-space-row-tuned_changed-${row.name}`}
	className="flex items-center gap-2 font-mono text-xs text-gray-700"
	>
	<code>{row.name}</code>
	<span className="text-muted-foreground">{row.type}</span>
	<span>{renderValue(row.from)}</span>
	<span aria-hidden="true">→</span>
	<span>{renderValue(row.to)}</span>
	</li>
	))}
	</ul>
	);
	}
	function TunedChangedRows({ rows }: { rows: TunedChangedRow[] }) {
	return (
	<ul className="mt-1 space-y-1">
	{rows.map((row) => (
	<li
	key={row.name}
	data-testid={`param-space-row-tuned_changed-${row.name}`}
	className="grid grid-cols-[1.5fr_1fr_1fr_auto_1fr] gap-x-4 items-center font-mono text-xs text-gray-700"
	>
	<code>{row.name}</code>
	<span className="text-muted-foreground justify-self-start">{row.type}</span>
	<span className="justify-self-end">{renderValue(row.from)}</span>
	<span aria-hidden="true" className="text-muted-foreground text-center">→</span>
	<span className="justify-self-start">{renderValue(row.to)}</span>
	</li>
	))}
	</ul>
	);
	}

[SoundMindsAI]

Review adjudication (Gemini Code Assist)

Commit landing fixes: df235610

Gemini Code Assist (2 findings)

#	Sev	Location	Verdict	Notes
1	High	ui/src/lib/proposal-param-space.ts:84	Accepted	Real null-safety bug — searchSpaceParams !== undefined && key in searchSpaceParams throws TypeError when searchSpaceParams is null (since null !== undefined is true and key in null throws). JSONB study.search_space.params is null-reachable at runtime. Fixed in df235610 with a truthiness guard + widened the type to Record | null | undefined. Added a null-search-space regression unit test.
2	Medium	ui/src/components/proposals/full-param-space-panel.tsx:67	Accepted	Genuine readability improvement — tunedChanged rows now use a CSS grid so name/type/from/→/to align vertically across rows (matching <ConfigDiffPanel>'s table columns). Fixed in df235610; component tests are layout-agnostic and stay green.

Outcomes

• Applied fixes (2): null-safe search-space guard (+ type widening + regression test); grid-aligned tuned-changed rows.
• Rejected (0): —
• Deferred (0): —

All 17 CI checks were green on the pre-fix SHA; the fix commit re-triggers CI. Ready for human review + merge once green.