docs: finalize feat_proposals_ui (PR #58) — move to implemented_features#59
Merged
Conversation
Post-merge finalization for feat_proposals_ui (squash commit 836a216, merged 2026-05-12 as PR #58). Edits: - Move docs/02_product/planned_features/feat_proposals_ui/ → docs/00_overview/implemented_features/2026_05_12_feat_proposals_ui/ - feature_spec.md §18 DoD: AC-1..AC-7 checked (cite the 47 new Vitest cases). Tutorial-flow box deferred to chore_tutorial_polish. - implementation_plan.md Status: Draft → Complete (PR #58, squash 836a216). - pipeline_status.md Implement + Done sections updated with merge metadata. - state.md: feat_proposals_ui replaces feat_github_webhook as the "most recent meaningful changes" head entry. Coverage line bumped from 122 → 171 UI tests across 32 files. Branch/Active-feature context refreshed. - CLAUDE.md Feature Status row 11: "Spec approved, plan pending" → "Complete (PR #58, merged 2026-05-12)" with the link updated to implemented_features/. - architecture.md ui/ "Where the code lives" listing extended with the src/app/proposals/ + proposals/[id]/ routes, the per-resource hook inventory, and the canonical enums.ts allowlist file. - MVP1 dashboard regenerated by pre-commit hook. No code changes — pure docs. Lands on docs/finalize-proposals-ui branch from origin/main (per impl-execute Step 8.0 post-merge guidance: the feature branch is dead after squash). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
SoundMindsAI
added a commit
that referenced
this pull request
Jun 3, 2026
…corecard alerts) (#431) * ci(security): add CodeQL SAST + write Dockerfile base-image digests literally Two follow-ups on the post-merge OSSF Scorecard surface (PR #430 closed the postcss vuln + ~50 pinning alerts; this closes the SAST finding + the 6 remaining containerImage alerts). CodeQL (#71): add .github/workflows/codeql.yml — GitHub first-party SAST on push/PR to main + weekly, scanning python + javascript-typescript with build-mode none. Closes the Scorecard "SAST tool is not run on all commits" finding and surfaces real code-level bugs on every PR. Action refs pinned to SHAs to match the repo's pinning posture. Dockerfile digests (#59/#60/#80-#83): revert the BASE_IMAGE ARG indirection back to literal `image@sha256:…` on each FROM. The pin was always real, but Scorecard's static parser only credits a digest it can see inline — an ARG-indirected digest reads as "unpinned", which is what kept all 6 containerImage alerts open (Dockerfile:24/46/79 + ui/Dockerfile:24/30/39, confirmed from the Scorecard SARIF locations). Writing tag+digest together also removes the override footgun Gemini flagged on PR #430; Dependabot bumps every FROM occurrence in lockstep, so the repeated node digest is not a sync hazard. Both Dockerfiles pass `docker buildx build --check`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: SoundMindsAI <eric.starr@soundminds.ai> * ci(security): builder stage inherits from deps (Gemini #431) Accept Gemini's finding on PR #431: have the ui builder stage `FROM deps` instead of re-deriving from the base image. deps already has pnpm, WORKDIR, and node_modules, so this drops a redundant `npm install -g pnpm@9` + the node_modules COPY, removes one base-image digest occurrence, and eliminates one of the two npmCommand Scorecard findings. A stage ref to a digest-pinned stage is still credited as pinned by Scorecard. node_modules is .dockerignore'd so `COPY . .` doesn't clobber the installed deps. Verified with a full `docker buildx build` of the ui image (next build + runner copy succeed). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: SoundMindsAI <eric.starr@soundminds.ai> --------- Signed-off-by: SoundMindsAI <eric.starr@soundminds.ai> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge finalization for
feat_proposals_ui(PR #58, squash commit836a216, merged 2026-05-12). Mirrors the pattern used by PR #57 (finalized #56), PR #46 (finalized #45), etc.docs/02_product/planned_features/feat_proposals_ui/→docs/00_overview/implemented_features/2026_05_12_feat_proposals_ui/chore_tutorial_polishimplementation_plan.mdStatus: Draft → Complete (PR feat(proposals-ui): /proposals list + /proposals/{id} detail (feat_proposals_ui) #58, squash836a216)pipeline_status.mdImplement + Done sections with merge metadatastate.md: new head entry replacingfeat_github_webhook; coverage line 122 → 171 UI tests across 32 files; branch/Active-feature context refreshedCLAUDE.mdFeature Status row 11 to "Complete (PR feat(proposals-ui): /proposals list + /proposals/{id} detail (feat_proposals_ui) #58, merged 2026-05-12)"architecture.mdui/listing with the new proposals routes + hook + enum file inventoryTest plan
make lint && make typecheck(no code changes — backend gates unchanged)cd ui && pnpm lint && pnpm typecheck(no code changes — frontend gates unchanged)🤖 Generated with Claude Code