updated rune images from ddragon#123
updated rune images from ddragon#123Soundofdarkness merged 2 commits intomasterfrom unknown repository
Conversation
|
@Rerago Sure, I addeded it to my todo list but this is not a priority for now tho since I want to fix the plugins first. But yeah no problem |
ghost
mentioned this pull request
|
Alright, i have added Treasure hunter manually for now, until we can figure out how to handle the larger images, since I dont have the time to fix that before this release. |
|
Should we put together a ci job for updating that? or just make them dynamic so that the client loads them every time. I'm unsure what would be better but I guess less traffic is better. |
update 8105
|
In itself, a CI job WOULD be enough. But then we would have to ignore the stat images. Since they are 35px and the current css needs 37px to display them correctly. The advantage of a client version would be that we are independent and don't have to release a new version just because Riot releases a new image. @Soundofdarkness Could you please merge that? I have changed the stat icons back to the current version. This solves the problem of too large icons for now. |
|
Yup, |
ghost
deleted the
2 participants
The PR is in the end the same as #23, but with current patch status.
Reason of the PR's is actually the Issue #122
As a side note it should be noted that the padding/margin of the StatMods has changed somewhat, making them appear somewhat larger in the tool. In my opinion, this should be adjusted in the tool so that later updates are not always dependent on keeping the old icons.
Btw: I am still in favor that these images should NOT be included in the tool itself and should rather be cached live. As you can see in the current example, the tool is otherwise constantly dependent on maintenance.
@11Tuvork28 Well, do you feel like adding that? Since I wanted to put currently no more coding in the project would be possibly something for you :D
Source: