tor-mode: register bearbrowser StaticPrefs group (140-ESR header gen)#45
Merged
Conversation
The 140-ESR tor-mode build failed: gfxUserFontSet.cpp can't find the generated mozilla/StaticPrefs_bearbrowser.h. Root cause: per-group StaticPrefs_<g>.h files are generated ONLY for groups in modules/libpref/moz.build's hardcoded pref_groups list. The bearbrowser.* prefs are in StaticPrefList.yaml (so StaticPrefsAll.h #includes the group) but 'bearbrowser' isn't in pref_groups on 140, so the per-group header is never emitted. (On 150 LibreWolf's source carries a librewolf group that branding renames; 140's source differs.) Fix: bearbrowser-patches.py now inserts 'bearbrowser' into pref_groups if absent (idempotent; the list is sorted() afterward). Verified: the regex inserts cleanly into the real esr140 moz.build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the tor-mode 140-ESR build: StaticPrefs_bearbrowser.h wasn't generated because 'bearbrowser' wasn't in libpref/moz.build's pref_groups (per-group headers generate only for listed groups). bearbrowser-patches.py now inserts it if absent. Verified the regex against real esr140 moz.build. A tor-mode build will confirm end-to-end.
🤖 Generated with Claude Code