Skip to content

fix: rollover tasks#82

Merged
NucleoFusion merged 3 commits intoSourcewareLab:devfrom
theantichris:fix/rollover-tasks
Mar 3, 2026
Merged

fix: rollover tasks#82
NucleoFusion merged 3 commits intoSourcewareLab:devfrom
theantichris:fix/rollover-tasks

Conversation

@theantichris
Copy link
Copy Markdown
Contributor

GetItems() in internal/models/daily/items.go was rolling over all tasks from the prior day regardless of status. Since I expressed some opinions in this fix I want to break it out in case there needs to be discussion.

  1. I am only rolling over pending and started tasks
  2. Started tasks keep the started status (Bullet Journal ideology)
  3. I extracted the filter to a helper function to make it testable
  4. Added unit tests just for this change (I would like add tests for any new changes I make)

I am happy to make changes is this doesn't fit with your vision for the code.

If and when this is merged in please release.

@NucleoFusion NucleoFusion merged commit 77769b3 into SourcewareLab:dev Mar 3, 2026
@theantichris theantichris deleted the fix/rollover-tasks branch March 3, 2026 15:16
@theantichris
Copy link
Copy Markdown
Contributor Author

@NucleoFusion I don't think this fix got released.

@NucleoFusion
Copy link
Copy Markdown
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants