Chore/update button link#35
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors documentation by introducing reusable MDX components for the 'Ready to Get Started' and 'Support and Community' sections, while also adding a new Integrations category and a detailed Webhooks setup guide. Feedback highlights the need for default values in the RichCardOption component to prevent 'undefined' classes, corrections to step titles and references in the Webhooks documentation, and improvements to UX consistency regarding disabled links and forum URLs.
| } | ||
|
|
||
| export const RichCardOption = ({ icon, title, description, badge, href }) => { | ||
| export const RichCardOption = ({ icon, title, description, badge, href, className, badgeClassName }) => { |
There was a problem hiding this comment.
The className and badgeClassName props should have default values (e.g., empty strings) to prevent the string "undefined" from being included in the component's class list when they are not provided by the parent component.
| export const RichCardOption = ({ icon, title, description, badge, href, className, badgeClassName }) => { | |
| export const RichCardOption = ({ icon, title, description, badge, href, className = "", badgeClassName = "" }) => { |
| **On ChirpStack:** Select the ***Integrations*** tab from the top or side navigation bar. | ||
| </NumberWithMdx> | ||
| <NumberWithMdx number={3}> | ||
| **Navigate to Integrations**<br/> |
There was a problem hiding this comment.
This step title is a duplicate of the previous step (Step 2). It should be updated to accurately describe the action of adding or creating the integration.
**Add Webhook / Integration**<br/>
| </NumberWithMdx> | ||
| <NumberWithMdx number={4}> | ||
| **Fill in the Connection Details**<br/> | ||
| Enter the **Webhook URL** you copied in `Step 3`. Ensure the **Method** is set to `POST`. |
There was a problem hiding this comment.
The reference to Step 3 is incorrect. The Endpoint URL was retrieved in Step 5 of the 'Get Webhook Endpoint from SpaceDF' section earlier in the document.
Enter the **Webhook URL** you copied in Step 5 of the previous section. Ensure the **Method** is set to POST.
| <tr className="border-b border-gray-100 dark:border-gray-800"> | ||
| <td className="py-3 text-gray-700 dark:text-gray-300">Device Not Appearing</td> | ||
| <td className="py-3 text-gray-700 dark:text-gray-300">DevEUI mismatch between platforms.</td> | ||
| <td className="py-3 text-gray-700 dark:text-gray-300">Ensure the `devEUI` in TTN/ChirpStack matches the one registered in **SpaceDF** exactly</td> |
There was a problem hiding this comment.
Missing punctuation at the end of the sentence for consistency with other entries in the troubleshooting table.
<td className="py-3 text-gray-700 dark:text-gray-300">Ensure the devEUI in TTN/ChirpStack matches the one registered in **SpaceDF** exactly.</td>
|
|
||
| <Cards> | ||
| <Cards.Card | ||
| style={{pointerEvents: "none"}} |
There was a problem hiding this comment.
Disabling pointer events on a card that includes an href without a visual indicator (such as a 'Coming Soon' badge) can lead to a confusing user experience. Consider adding a badge or removing the href until the destination content is fully ready for interaction.
| /> | ||
| </RichCardOptions> | ||
|
|
||
| *More integrations coming soon. Have a request? [Let us know.](https://forum.df.technology/)* |
There was a problem hiding this comment.
The forum link https://forum.df.technology/ is inconsistent with the community link used elsewhere in the documentation (https://docs.spacedf.com/community). Please verify if this is the intended destination.
1 participant
No description provided.